Skip to content

Changed "View Session" link URL #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TeddyCho wants to merge 1 commit into from
Closed

Changed "View Session" link URL #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oshc/main/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown">Sessions <span class="caret"></span></a>
<ul class="dropdown-menu" role="menu">
<li><a href="https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q" target="_blank">View Session</a></li>
<li><a href="https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q/videos/" target="_blank">View Session</a></li>

@tapaswenipathak tapaswenipathak Dec 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor glitch here, the issue needs the url to be updated to https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q/videos and not to https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q/videos/.

Results are different 👇

screen shot 2017-12-28 at 10 04 44 pm

screen shot 2017-12-28 at 10 04 56 pm

Need to have the second one.

@jarifibrahim jarifibrahim Dec 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @tapasweni-pathak 👍

<li><a href="{% url 'request_session' %}" target="_blank">Request a Session</a></li>
</ul>
</li>
Expand Down