Fix for #210: Removed target attribute from some links.#227
Merged
Conversation
anubhakushwaha
approved these changes
Jan 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
predevbranch.Which issue does this PR fix?:
Fixes issue #210 (links undesirably opening in new tab).
This PR removes the target attribute entirely for each anchor tag mentioned in issue 210 inside /oshc/main/templates/base.html. To allow for consistency, I opted to completely remove the target attribute so that it matches other in-tab-opening links on the same page. This removal has been applied to the following links:
Why do we need this PR?:
UI/UX alteration to provide for favorable user interaction (altered links don't open in new tab when they don't need to).
Testing instructions:
I have taken the following steps, and am leaving them unchecked below for you to use:
git fetch https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io/predev)python manage.py collectstatic)python manage.py runserver)TODOs (if any):
None
A picture of a cute animal (not mandatory but encouraged):

Old but good: