Adding Curie temperature estimation functionality to rockmagpy#776
Merged
Conversation
apivarunas
requested review from
Swanson-Hysell
and removed request for
duserzym
apivarunas
requested review from
Copilot
and removed request for
Swanson-Hysell
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new function estimate_curie_temperature to the pmagpy/rockmag.py module for estimating Curie temperature from high-temperature susceptibility curves using multiple methods including first derivative minimum, second derivative maximum, and zero-crossing analysis, with an optional interactive inverse susceptibility method using Bokeh.
Key changes:
- New
estimate_curie_temperaturefunction with support for multiple estimation methods and interactive visualization - Additional Bokeh imports (
ColumnDataSource,PointDrawTool,CustomJS,Div) to support interactive fitting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 15 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is me porting over to
rockmag.pymy attempt ( #726 ) at addressing #709 inipmag.py. Since the X-T plotting functionality inrockmag.pylooks pretty robust and uses the samenp.gradientlogic for the derivatives I put in that PR, I figured that the useful thing I could do would be to add the Curie temperature estimation.I've not only done it but added a significantly better version of the inverse temperature estimation, wherein the user can do it interactively by dragging a line in a Bokeh plot. pats self and Copilot on the back...
The derivative-based estimates are easy and automatic.
Additional thought: If this passes muster, I can make one more commit in in #726 by simply removing(!) the
curie.pyfunction fromipmag.py, and close that loop. Then, the rock magnetic functions live inrockmag.pyand there isn't duplication.