Removing deprecated API calls #798#803
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #798, whererein the deprecated API
pkg_resourceswas being used. Since this may be removed by November, and it seemed more difficult to pin to an older version ofSetuptools, I rewrote using the most up-to-date API as discussed here: https://importlib-resources.readthedocs.io/en/latest/migration.html. The only slight oddity was thatimportlib_resourcesis itself a backport ofimportlib.resources, but that's something currently handled in the imports that could be fixed later.I tested this by running the command:
import pmagpy.pmag as pmagin the python interpreter, which used to raise the error, and the error is no longer raised.