Fixing duplication in continents.py#807
Merged
apivarunas merged 1 commit intoNov 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apivarunas
added a commit
that referenced
this pull request
Dec 16, 2025
* Plot map fix (#810) * develop some more tests * update plot_map to return axes * implement axes fix to show two continents * new tests removed from this plot_map_fix branch * use elope_path instead of rewriting Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix orthographic typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * edits to PR --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: apivarunas <apiv93@gmail.com> * change from predetermined index for percentiles to direct percentile calculation in find_ei and find_ei_kent (#795) After reviewing this PR and concurring that it fixes the issue, merging. * remove duplication, fix docs, readability (#807) * simple style fixes via ruff (#812) * Working through errors / warnings in ipmag (#813) * slowly fixing errors and warnings * additional warning fixes * additional Exception clarity * clearing bare excepts * addressing review comments * adding ipmag tests * add to same file * added watson conglomerate tests * renamed file --------- Co-authored-by: Nick Swanson-Hysell <nicks-h@umn.edu> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closed
Swanson-Hysell
added a commit
that referenced
this pull request
Feb 28, 2026
* Plot map fix (#810) * develop some more tests * update plot_map to return axes * implement axes fix to show two continents * new tests removed from this plot_map_fix branch * use elope_path instead of rewriting Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix orthographic typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * edits to PR --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: apivarunas <apiv93@gmail.com> * change from predetermined index for percentiles to direct percentile calculation in find_ei and find_ei_kent (#795) After reviewing this PR and concurring that it fixes the issue, merging. * remove duplication, fix docs, readability (#807) * simple style fixes via ruff (#812) * Working through errors / warnings in ipmag (#813) * slowly fixing errors and warnings * additional warning fixes * additional Exception clarity * clearing bare excepts * addressing review comments * adding ipmag tests * add to same file * added watson conglomerate tests * renamed file --------- Co-authored-by: Nick Swanson-Hysell <nicks-h@umn.edu> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the double-defined function
get_continentand edited docstring to reflect all options. This fixes the internals of the program as regards duplication but does not fully address #806 in terms of the actual latitude/longitude and plotting.