Hemalvarambhia issue 48#58
Merged
Merged
Conversation
…nions, moved messages to the Quaternions package.
the Extensions package with the aforementioned.
Contributor
|
@SergeStinckwich The QuaternionExtensions package has not been deleted from the file system yet. Initially, I unloaded the said package from Pharo and the tests still passed. This would indicate that we can safely delete it. |
Member
Author
|
You have to modify the BaselineOfPolyMath that load the packages. |
Contributor
|
Presumeably I just remove L60 of that file: https://github.com/PolyMathOrg/PolyMath/blob/master/src/BaselineOfPolyMath/BaselineOfPolyMath.class.st is that right? |
Member
Author
|
No enough, replace two lines : package: 'Math-Quaternion' with: [ spec requires: #('Math-Complex') ];
package: 'Math-QuaternionExtensions' with: [ spec requires: #('Math-DHB-Numerical' 'Math-Quaternion' 'Math-Polynomials') ];with package: 'Math-Quaternion' with: [ spec requires: #('Math-Complex' 'Math-DHB-Numerical' 'Math-Polynomials') ]; |
into Quaternion, as recommended by Serge.
Member
Author
|
ok I merge your changes on master. Next time you should do a PR on development branch. Look at the contributing guide here: https://github.com/PolyMathOrg/PolyMath/blob/development/CONTRIBUTING.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hemal fix #48