testPrintAndEvaluate test fails in Pharo 7.0#72
Conversation
|
Hi Serge 1.of course you are aware of the fact that you can delete or put into comments the pragma. 2.OpalCompiler >> evaluate: is deprecated in 7.0. for example 3.you let a var-accessor return something without changing the underlying var, imo a very clever solution that obviously works without problems, but a trick nevertheless. it probably makes sense if the pharo chiefs do away with pragmas that are not simple to find, but i guess they dont expect everybody and his aunt to find your clever trick. if they have forgotten to add a possibility to change the time for a single test method, perhaps one should inform them of that problem. in a way this change proposes that one should always find a workaround in polymath for problems that will of course regularly occur in a development version of pharo (and after a while can disappear). personally i would think its no problem if tests are red in a development version of pharo, as long as everything is green in the stable pharo. lets say the pharo chiefs add such a possibility, are you sure that you will not forget to adapt ArbitraryPrecisionFloatTest class>>defaultTimeLimit and the rest? actually thats a reason why i dont like to do anything - polymath or whatever - in pharo7. i run too often into bugs & problems.
|
|
if the change is the reason for the difference in the results of appveyor and travis, then they perhaps build different 7.0 images or use different operating systems. in the first case i would just wait & repeat, in the second case, mmh that would be difficult . |
|
with 2. i made an error, its only on the class side deprecated, hence this is no problem |
| } | ||
|
|
||
| { #category : #accessing } | ||
| ArbitraryPrecisionFloatTest class >> defaultTimeLimit [ |
There was a problem hiding this comment.
Can this block be inlined as
defaultTimeLimit [ ^ 120 seconds ]
or, again, is what you've done the convention?
|
Werner, I don't understand the point 3. Can you try to be actionnable ? |
|
Why is XXXCompiler evaluate: deprecated ??? Isn't it a usefull API ??? I doubt that replacing by So what is the recommended replacement? |
|
I think the reason is that you can have many compilers in your image. In Pharo 6.1, you have the old Compiler and new one OpalCompiler. In Pharo 7.0, old Compiler has been removed and replaced by OpalCompiler. If you look at my changes, you will see that I replace :
|
|
Ah OK, that's fine then! The message from Werner were not that clear ;) |
Fix #71