Skip to content

Fixes a bug to find module manifest when there are no build manifest #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jaykul merged 2 commits into from
Mar 1, 2020
Merged

Fixes a bug to find module manifest when there are no build manifest #90

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3266d6a
Fixes a bug to find module manifest when there are no build manifest
johlju Feb 29, 2020
84709a8
Make the "same module" tests more significant
Jaykul Mar 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make the "same module" tests more significant
  • Loading branch information
@Jaykul
Jaykul committed Mar 1, 2020
commit 84709a8e27f22513c0af9eadb4bd255762ee1807
29 changes: 21 additions & 8 deletions Tests/Integration/Source1.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ Describe "Regression test for #84: Multiple Aliases per command will Export" -Ta

Describe "Supports building without a build.psd1" -Tag Integration {
Copy-Item $PSScriptRoot\Source1 TestDrive:\Source1 -Recurse
# This is the old build, with a build.psd1
$Output = Build-Module TestDrive:\Source1\build.psd1 -Passthru
$ManifestContent = Get-Content $Output.Path
$ModuleContent = Get-Content ([IO.Path]::ChangeExtension($Output.Path, ".psm1"))
Remove-Item (Split-Path $Output.Path) -Recurse

# Then remove the build.psd1 and rebuild it
Remove-Item TestDrive:\Source1\build.psd1

$Build = @{ }
Expand All @@ -105,6 +112,8 @@ Describe "Supports building without a build.psd1" -Tag Integration {

It "Creates the same module as with a build.psd1" {
$Build.Metadata = Import-Metadata $Build.Output.Path
Get-Content $Build.Output.Path | Should -Be $ManifestContent
Get-Content ([IO.Path]::ChangeExtension($Build.Output.Path, ".psm1")) | Should -Be $ModuleContent
}

It "Should update AliasesToExport in the manifest" {
Expand All @@ -115,26 +124,30 @@ Describe "Supports building without a build.psd1" -Tag Integration {
$Build.Metadata.FunctionsToExport | Should -Be @("Get-Source", "Set-Source")
}
}
Describe "Supports building without a build.psd1 and not specifying a module manifest" -Tag Integration {
Describe "Supports building discovering the module without a build.psd1" -Tag Integration {
Copy-Item $PSScriptRoot\Source1 TestDrive:\source -Recurse

# This is the old build, with a build.psd1
$Output = Build-Module TestDrive:\source\build.psd1 -Passthru
$ManifestContent = Get-Content $Output.Path
$ModuleContent = Get-Content ([IO.Path]::ChangeExtension($Output.Path, ".psm1"))
Remove-Item (Split-Path $Output.Path) -Recurse

# Then remove the build.psd1 and rebuild it
Remove-Item TestDrive:\source\build.psd1

Push-Location -StackName 'IntegrationTest' -Path TestDrive:\

$Build = @{ }

It "No longer fails if there's no build.psd1" {
$BuildParameters = @{
SourcePath = "TestDrive:\source"
OutputDirectory = "TestDrive:\Result1"
VersionedOutputDirectory = $true
}

$Build.Output = Build-Module @BuildParameters -Passthru
$Build.Output = Build-Module -Passthru
}

It "Creates the same module as with a build.psd1" {
$Build.Metadata = Import-Metadata $Build.Output.Path
Get-Content $Build.Output.Path | Should -Be $ManifestContent
Get-Content ([IO.Path]::ChangeExtension($Build.Output.Path, ".psm1")) | Should -Be $ModuleContent
}

It "Should update AliasesToExport in the manifest" {
Expand Down