Skip to content

Update new-pssession.action.ps1#159

Merged
FriedrichWeinmann merged 2 commits into
PowershellFrameworkCollective:developmentfrom
dgoldman-msft:development
Sep 15, 2021
Merged

Update new-pssession.action.ps1#159
FriedrichWeinmann merged 2 commits into
PowershellFrameworkCollective:developmentfrom
dgoldman-msft:development

Conversation

@dgoldman-msft

Copy link
Copy Markdown
Contributor

Added functionality to use port for session

Added functionality to use port for session

@FriedrichWeinmann FriedrichWeinmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs are ok-ish, but that double-o is a menace
;)

(Demo Review with black humor for teaching Dave the tool, not an actual review)

$params = @{
Name = 'new-pssession'
Action = $action
Name = 'new-pssession'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get your hands off my tabs!

Name = 'new-pssession'
Action = $action
Name = 'new-pssession'
Action = $action

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs, Tabs, Tabs

Comment thread PSModuleDevelopment/internal/buildActions/new-pssession.action.ps1 Outdated
@FriedrichWeinmann FriedrichWeinmann merged commit 5ff669a into PowershellFrameworkCollective:development Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants