MRG: Forgotten weights arg in barycenter funcs by hichamjanati · Pull Request #106 · PythonOT/POT

hichamjanati · 2019-10-19T10:08:04Z

Tiny fix: the weights arg was not passed in the general barycenter funcs.
Loop counter in barycenter_unbalanced was outside the loop -> change while loops to for loops
Adding 1e-16 to avoid 0 when dual variables are returned was too conservative and causes large differences in the exponentials. changed to 1e-300

rflamary · 2019-10-24T12:39:34Z

Thank you Hicham !

Hicham Janati added 3 commits October 19, 2019 12:05

add weights arg in generic barycenter func

2f37412

same for unbalanced

a919f96

fix loop counter in barycenter + precision of dual variables

161d68a

hichamjanati changed the title ~~FIX: Forgotten weights arg in barycenter funcs~~ MRG: Forgotten weights arg in barycenter funcs Oct 21, 2019

rflamary merged commit 65ca6bf into PythonOT:master Oct 24, 2019

rflamary mentioned this pull request Feb 25, 2020

Missing weights in unbalanced.barycenter_unbalanced #128

Closed

Provide feedback