Skip to content

change precision EPSILON in C code#217

Merged
rflamary merged 3 commits into
masterfrom
precision_concern
Nov 12, 2020
Merged

change precision EPSILON in C code#217
rflamary merged 3 commits into
masterfrom
precision_concern

Conversation

@ncourty

@ncourty ncourty commented Nov 12, 2020 •
edited by rflamary
Loading

Copy link
Copy Markdown
Collaborator

Types of changes

  • Docs change / refactoring / dependency upgrade
  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Problem INFEASIBLE cast where it should not happen.

Fixes #126

Fixes #93

How has this been tested (if it applies)

The minimal code to repdroduce the bug is now working.
A user tested on its own data and now the problem is also working

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@codecov

codecov Bot commented Nov 12, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #217 (b554ebd) into master (93785eb) will increase coverage by 3.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   88.48%   92.40%   +3.92%     
==========================================
  Files          20       16       -4     
  Lines        3196     3056     -140     
==========================================
- Hits         2828     2824       -4     
+ Misses        368      232     -136

agramfort
agramfort reviewed Nov 12, 2020
View reviewed changes
Comment thread ot/lp/network_simplex_simple.h Outdated
rflamary
rflamary reviewed Nov 12, 2020
View reviewed changes
Comment thread ot/lp/network_simplex_simple.h Outdated
Comment thread ot/lp/network_simplex_simple.h Outdated
@ncourty

ncourty commented Nov 12, 2020

Copy link
Copy Markdown
Collaborator Author

Finally I only changed the final test value against EPSILON to test wether the problem is infeasible or not. It drastically limitates the side effects in the resolution of the problem.

@rflamary rflamary merged commit cb3e24a into master Nov 12, 2020
@ncourty ncourty deleted the precision_concern branch November 12, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort left review comments

@rflamary rflamary rflamary left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Infeasible solution for EMD but inputs are in the simplex? Not in simplex -- two sets of largely different sizes

3 participants

@ncourty @agramfort @rflamary