apps/meteor/server/modules/notifications/notifications.module.ts (1)

543-550: ⚡ Quick win

Remove the implementation comment directive in notifyVideoConference

Line 548 adds an implementation comment (@ts-expect-error), which conflicts with the repository guideline. Prefer a typed local eventName value and emit that directly.

Suggested change

 	notifyVideoConference<P extends string, E extends string>(
 		callId: P,
 		event: E extends ExtractNotifyUserEventName<'video-conference', P> ? E : never,
 		...args: `${P}/${E}` extends StreamKeys<'video-conference'> ? StreamerCallbackArgs<'video-conference', `${P}/${E}`> : never
 	): void {
-		// `@ts-expect-error` - as we currently only have one event for the 'video-conference' stream, typescript doesn't like the destructuring
-		return this.streamVideoConference.emit(`${callId}/${event}`, ...args);
+		const eventName = `${callId}/${event}` as `${string}/discussionUpdated`;
+		return this.streamVideoConference.emit(eventName, ...args);
 	}

As per coding guidelines, **/*.{ts,tsx,js} should “Avoid code comments in the implementation”.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/meteor/server/modules/notifications/notifications.module.ts` around
lines 543 - 550, The `notifyVideoConference` method currently uses a
`@ts-expect-error` comment to suppress a TypeScript error on the emit call,
which violates the coding guideline to avoid code comments in implementations.
Instead of the inline template literal `${callId}/${event}` in the emit call,
create a typed local constant variable `eventName` that holds this concatenated
value, then pass that variable to the `this.streamVideoConference.emit()` call.
This allows TypeScript to properly infer the type without requiring the error
suppression directive.

Source: Coding guidelines

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes