Patch for Util.java to fix decoding issue when message > 2048 #110
Patch for Util.java to fix decoding issue when message > 2048 #110mhou1981 wants to merge 2 commits into
Conversation
Fix the base64decodedInflated where return input string after base 64 decode is greater than 2048 bytes will cause decompressed XML to have invalid format.
Reduce operation needed to find the best match for byte array length
|
Can you provide a test with a message > 2048? |
|
A Saml response contain a X509 Certificate of 2048 in size will be a valid
test.
Cheers
…On Tue, Jun 20, 2017 at 1:51 AM Sixto Martin ***@***.***> wrote:
Can you provide a test with a message > 2048?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACz-fCQAo02bDHmiSID_vEHY6cQQik7gks5sF4gRgaJpZM4N-8C7>
.
|
|
For example: |
|
Ok, I had not experienced that issue since java-saml uses only base64decodedInflated on HTTP-Redirect binding where Signature is not embed on the XML. |
3 participants
Fix the base64decodedInflated where return input string after base 64 decode is greater than 2048 bytes will cause decompressed XML to have invalid format.