Skip to content

Make constants constant#324

Closed
ThePetrov wants to merge 1 commit into
SAML-Toolkits:masterfrom
atlassian-forks:make-constants-final
Closed

Make constants constant#324
ThePetrov wants to merge 1 commit into
SAML-Toolkits:masterfrom
atlassian-forks:make-constants-final

Conversation

@ThePetrov

Copy link
Copy Markdown
Contributor

The properties of the Constants class did not have the final property, making modifications possible. This PR makes them final.

@mauromol

mauromol commented Apr 2, 2021

Copy link
Copy Markdown
Contributor

See #308.

@ThePetrov

Copy link
Copy Markdown
Contributor Author

Thanls @mauromol , I'll close this PR as it's a duplicate.

@ThePetrov ThePetrov closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants