Skip to content

Add synchronizedResolver property to Assembler#445

Open
devxoul wants to merge 2 commits into
Swinject:masterfrom
devxoul:assembler-synchornized
Open

Add synchronizedResolver property to Assembler#445
devxoul wants to merge 2 commits into
Swinject:masterfrom
devxoul:assembler-synchornized

Conversation

@devxoul

@devxoul devxoul commented Feb 25, 2020

Copy link
Copy Markdown

It resolves #221

@opfeffer

Copy link
Copy Markdown

Whats the status of this PR? Would be very happy to see this land? cc/ @yoichitgy

@bryanwagner

bryanwagner commented Aug 28, 2022

Copy link
Copy Markdown

This would have been handy to have at the moment for me as well; I could create an extension function if only container wasn't private.

Edit: I spoke too soon. This extension appears to be working for me:

extension Assembler {
    public var synchronizedResolver: Resolver {
        let internalResolver = resolver
        if let it = internalResolver as? Container {
            return it.synchronize()
        } else {
            return internalResolver
        }
    }
}

@ursusursus

Copy link
Copy Markdown

why did this die?

@peterkos

Copy link
Copy Markdown

Any updates? cc @mpdifran

@maxim-chipeev

maxim-chipeev commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

Hey @peterkos, with #514 and #523 this should be resolved on 2.8.3. (as long as you use a synchronized Container)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assembly/Assembler need thread safety

6 participants