Carthage migrating a project from framework bundles to XCFrameworks#497
Carthage migrating a project from framework bundles to XCFrameworks#497nickaroot wants to merge 2 commits into
Conversation
|
Thanks, @nickaroot for making the PR! Supporting XCFrameworks is nice😃 @mpdifran Would you review the PR? I think you have some idea about XCFrameworks. @1ucas Would you check whether we should update |
|
Sure! I'll be on it today. |
|
Yeah I can take a look to make sure it still works for xcframeworks and old fat frameworks! |
|
Not sure it still works with usual frameworks (arm64 not excluded) Makes sense to merge it into 'xcframework' branch, not master |
|
Ah gotcha, I thought we'd be able to avoid making a breaking change on |
1ucas
left a comment
1ucas
left a comment
There was a problem hiding this comment.
Hello, @nickaroot !
As you can see at the travis.yml file, we now enforce the project generation at our CI server.
So, to unsure everything will work as expected and we'll keep consistent project configurations across builds, all changes at the Swinject.xcodeproj must also be made at the project.yml template.
|
Changes added, successfully tested with |
|
Sorry, I merged PR #502 that might solve the same issue before reminding myself of this PR 🙇♂️ @nickaroot Did PR #502 solve the same issue? or do we have some differences in this PR to merge? |
4 participants
Hey, there is awesome Carthage feature for Xcode 12+ (https://github.com/Carthage/Carthage#migrating-a-project-from-framework-bundles-to-xcframeworks) with no need to apply a workaround
It's could be cool to merge it into a new 'xcframework' branch like an optional feature
Anyone can use it with
carthage update --use-xcframeworks