Support Swift 3 and Xcode 8.#6
Merged
Merged
Conversation
Migrating to swift3, also fixes unit tests.
Member
Author
|
Need to fix .travis.yml. |
… issue not running tests.
yoichitgy
commented
Oct 16, 2016
| get { | ||
| guard let obj = self as? AnyObject else { | ||
| fatalError("Property feature is not supported unless self is AnyObject.") | ||
| } |
Member
Author
There was a problem hiding this comment.
Need to check this part can be removed completely.
yoichitgy
commented
Oct 16, 2016
| private func setProperties(newProperties: [String: AnyObject]) { | ||
| guard let obj = self as? AnyObject else { | ||
| fatalError("Property feature is not supported unless self is AnyObject.") | ||
| } |
Member
Author
There was a problem hiding this comment.
Need to check this part can be removed completely.
Member
Author
|
Thanks @jakubvano, I guess I added the |
The type check was misunderstanding about AnyObject, NSObject and requirement of objc_get/setAssociatedObject.
Member
Author
|
Removed the commented out code by be48d02 because the type check was just misunderstanding about AnyObject, NSObject and requirement of objc_get/setAssociatedObject. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated the project to support Swift 3 and Xcode 8.
This pull request consists of