Skip to content

V2: Generics, Go 1.20 and associated tweaks#73

Merged
ripexz merged 16 commits into
masterfrom
fix-generics
Apr 26, 2023
Merged

V2: Generics, Go 1.20 and associated tweaks#73
ripexz merged 16 commits into
masterfrom
fix-generics

Conversation

@ripexz

@ripexz ripexz commented Apr 26, 2023

Copy link
Copy Markdown
Member
  • Includes Enhancement: Generic funcs #71 (generics, breaking change)
  • Reworked goutil.Expand to use golang.org/x/tools/go/packages (breaking change)
  • Cleaned up imageutil/sniff.go to remove unused param (breaking change)
  • Other small fixes as a result of Go upgrade and linter complaints
  • Chore: Switch from Travis to GHA
  • Chore: Switch from Codecov to Coveralls

@ripexz ripexz force-pushed the fix-generics branch 2 times, most recently from 83b0385 to 4966a1d Compare April 26, 2023 08:25
@tigh-latte

Copy link
Copy Markdown
Contributor

Can't wait for this to go in

@ripexz ripexz force-pushed the fix-generics branch 7 times, most recently from 82f1c6b to 33e5c7e Compare April 26, 2023 09:41

@tigh-latte tigh-latte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the moon

@ripexz ripexz mentioned this pull request Apr 26, 2023
@ripexz ripexz requested review from a team April 26, 2023 10:24
Comment thread go.mod Outdated
@ripexz ripexz requested a review from rafaeljusto April 26, 2023 11:28

@rafaeljusto rafaeljusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Amazing work 👏

@ripexz ripexz merged commit c8e4d01 into master Apr 26, 2023
@ripexz ripexz deleted the fix-generics branch April 26, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants