Enhancement: DetachContext and Generic sync.Map#74
Merged
Conversation
twariel
approved these changes
Apr 27, 2023
ripexz
reviewed
May 2, 2023
ripexz
left a comment
ripexz
left a comment
Member
There was a problem hiding this comment.
Some unit tests would be nice too... 👀
Contributor
Author
|
@ripexz I've done all this here now |
Pull Request Test Coverage Report for Build 4957863225
💛 - Coveralls |
ripexz
reviewed
May 12, 2023
ripexz
approved these changes
May 12, 2023
ripexz
left a comment
ripexz
left a comment
Member
There was a problem hiding this comment.
LGTM, but please squash
And tag + release v2.1.0
ripexz
approved these changes
May 12, 2023
ripexz
left a comment
ripexz
left a comment
Member
There was a problem hiding this comment.
LGTM, but please squash
And tag + release v2.1.0
Pull Request Test Coverage Report for Build 4958638494Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've a SyncMap implementation here that would be great to centralise.
Also a detachcontext implementation was added into apigo that would also be great to make general until go adds it to the standard library.