Clean up our mutex, fix try_lock not hooking into assert mechanism#1219
Merged
Conversation
Adlai-Holler
commented
Nov 7, 2018
|
|
||
| #import <assert.h> | ||
| #import <os/lock.h> | ||
| #import <pthread.h> |
Member
Author
There was a problem hiding this comment.
Note: pthread is still imported for ASDisplayNodeThreadIsMain function (no "main thread" in libcxx).
maicki
approved these changes
Nov 7, 2018
maicki
left a comment
maicki
left a comment
Contributor
There was a problem hiding this comment.
Nice work and this will make sure our asserts actually holding while using tryLock :)
Adlai-Holler
changed the title
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
…extureGroup#1219) * Clean up our mutex * Placement new import * Privatize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might want to use split diff for this.
Just a major overhaul to clear some space. Note: AS_CHECK_LOCKING_SAFETY is gone – if we have asserts that are failing despite correct usage of our APIs, we need to comment them out and address them.