Skip to content

Add copy sematic to userInfo property in ASTextRunDelegate#1719

Merged
vovasty merged 1 commit into
TextureGroup:masterfrom
hanton:fix-ASTextRunDelegate-userInfo-property
Nov 12, 2019
Merged

Add copy sematic to userInfo property in ASTextRunDelegate#1719
vovasty merged 1 commit into
TextureGroup:masterfrom
hanton:fix-ASTextRunDelegate-userInfo-property

Conversation

@hanton

@hanton hanton commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

For attributes whose type is an immutable value class that conforms to the NSCopying protocol, it almost always should specify copy in the property declaration.

@hanton hanton changed the title Add copy sematic to userInfo in ASTextRunDelegate Add copy sematic to userInfo property in ASTextRunDelegate Nov 12, 2019

@vovasty vovasty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable. thanks!

@vovasty vovasty merged commit 37e2830 into TextureGroup:master Nov 12, 2019
@hanton hanton deleted the fix-ASTextRunDelegate-userInfo-property branch November 13, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants