Skip to content

Revert #788 – Interface State Runloop Queue#861

Closed
Adlai-Holler wants to merge 1 commit into
masterfrom
AHRevertInterfaceStateQueue
Closed

Revert #788 – Interface State Runloop Queue#861
Adlai-Holler wants to merge 1 commit into
masterfrom
AHRevertInterfaceStateQueue

Conversation

@Adlai-Holler

@Adlai-Holler Adlai-Holler commented Mar 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Unfortunately, diff #788 has a few issues that need to be resolved before we can re-land it.

This reverts the diff until we can get these issues resolved.

maicki
maicki approved these changes Mar 28, 2018 •
edited
Loading
View reviewed changes
@ghost

ghost commented Mar 28, 2018

Copy link
Copy Markdown
1 Warning
⚠️ This is a big PR, please consider splitting it up to ease code review.

Generated by 🚫 Danger

@appleguy

appleguy commented Mar 28, 2018

Copy link
Copy Markdown
Member

@Adlai-Holler thanks for putting this up — it sounds like there is a clear need to disable this by default.

To that end, I've asked my team to make this a P0 and we'll either submit a PR today that accomplishes this (with all the coalescing code bypassed by default, and original timing unchanged) — or alternatively we can land this revert if the path to disable has any complications.

I'll let you guys know within a few hours what we plan to do. Sorry to hear this has created some issues!

@Adlai-Holler

Adlai-Holler commented Mar 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

OK @appleguy that's super reasonable IMO. To disable the coalescing by default, modify the + (ASConfiguration *)defaultConfiguration method in ASConfigurationInternal.m and remove the Coalescing flag there.

@Adlai-Holler

Adlai-Holler commented Mar 29, 2018

Copy link
Copy Markdown
Member Author

Superseded by #862

@appleguy

appleguy commented Mar 29, 2018

Copy link
Copy Markdown
Member

Thanks for being on top of this - glad we could resolve quickly with a minimum of risk on the other PR.

@appleguy appleguy deleted the AHRevertInterfaceStateQueue branch March 29, 2018 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maicki maicki maicki approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@appleguy appleguy Awaiting requested review from appleguy

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Adlai-Holler @appleguy @maicki