Fix pager node for interface coalescing#877
Merged
Adlai-Holler merged 17 commits intoMay 19, 2018
Merged
Conversation
Adlai-Holler
approved these changes
May 16, 2018
Adlai-Holler
left a comment
Adlai-Holler
left a comment
Member
There was a problem hiding this comment.
This diff looks fine, thanks for fixing! Just two typos and then we'll merge this one.
|
|
||
| /** | ||
| * Called just after the view is added to a window. | ||
| * Note: this may be called multiple times during view controller transitions. To overcome this: use didEnterVisibleState or it's equavalents. |
Member
There was a problem hiding this comment.
nit: or its equivalents, no apostrophe
|
|
||
| - (void)didEnterHierarchy { | ||
| ASDisplayNodeAssertMainThread(); | ||
| ASDisplayNodeAssert(!_flags.isEnteringHierarchy, @"You should never call -willEnterHierarchy directly. Appearance is automatically managed by ASDisplayNode"); |
Member
There was a problem hiding this comment.
Update. comment You should never call -didEnterHierarchy
Member
|
(Sorry Max) One more thing, could you add a line to the changelog describing the fix? |
Contributor
Author
|
Done, sorry keep forgetting that :). |
Contributor
|
@wsdwsd0829 I think you accidentally closed the PR - reopening :) |
Contributor
Author
|
On Thu, May 17, 2018 at 7:36 PM Michael Schneider ***@***.***> wrote:
Reopened #877 <#877>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#877 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFFq5HNLsnzOTl36LBLk-ihnTkJnsMuCks5tzjOngaJpZM4TNqGn>
.
Oops thanks
… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This suppose to fix #845 from interface coalescing point of view.