Feature: add client/server search type toggle to dropdown, multiselect and tags input#16856
Merged
johnsoncherian merged 6 commits intoJun 24, 2026
Conversation
Adds a "Type" toggle (Client side / Server side) under "Show search in options" in the Dropdown's additional actions. Server mode stops client-side filtering and highlighting so backend-filtered results pass through untouched; search text is still exposed and onSearchTextChanged still fires. Also fixes conditionallyRender being ignored for DropdownV2 in the inspector. Closes ToolJet/tj-ee#5193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
❌ Deploy Preview for storybook-tooljet failed.
|
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… input Mirrors the dropdown server-side search toggle onto Multiselect and Tags Input. Server mode short-circuits client-side option filtering (and highlighting on Multiselect). Tags Input gates on its existing "Turn on search" toggle since it has no separate search-input toggle. Also adds both widgets to the inspector conditionallyRender allowlist. Relates to: ToolJet/tj-ee#5193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move the Tags Input search type toggle into the Tags section directly below "Turn on search" (rendered explicitly there) instead of additional actions. Harden all serverSideSearch guards to strict `=== true` so a non-boolean resolved value can never disable client-side filtering. Relates to: ToolJet/tj-ee#5193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Tags Input filters options by input text in a useMemo before passing them to react-select, so gating filterOption alone left server mode still filtering. Skip the client-side input match in that memo when server-side search is on. Relates to: ToolJet/tj-ee#5193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nithindavid
changed the title
Server-side search renders all options unfiltered, exposing a latent crash when an option/tag has a numeric (or boolean) value: the "already exists" check and label filters called .toLowerCase()/.includes() directly on the raw value, and optional chaining only guarded null. Coerce with String(... ?? '') in TagsInputMenuList dedup check and in TagsInput filteredOptions memo + react-select filterOption. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
johnsoncherian
changed the base branch from
lts-3.16
to
chore/release-3.20.185-lts
johnsoncherian
merged commit 2d9d9ec
into
chore/release-3.20.185-lts
80 of 84 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 What this does
Adds a Search type toggle (Client side / Server side) to the Dropdown, Multiselect, and Tags Input widgets so search can be handed to a backend instead of filtering a pre-loaded list. In server mode the widget stops filtering and highlighting options locally, letting backend-filtered results render untouched, while still exposing
searchTextand firingonSearchTextChanged.Closes ToolJet/tj-ee#5193
🔀 Changes
serverSideSearchclient/server toggle to Dropdown and Multiselect (under "Show search in options") and Tags Input (under "Turn on search"), shown only when search is enabled.conditionallyRenderbeing ignored for Dropdown, Multiselect, and Tags in the inspector (the widgets were missing from the allowlist).🧪 How to test
searchText/onSearchTextChangedstill update and fire.searchTextononSearchTextChangedand bind its result to the options — confirm results are not re-filtered client-side.