feat(ui5-dialog): focus goes on entire dialog for drag and resize#13632
Merged
Conversation
…rations JIRA: BGSOFUIRODOPI-3659
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13632--ui5-webcomponents-preview.netlify.app |
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
s-todorova
force-pushed
the
dialog-resize-handler-acc
branch
from
efda0f2 to
6aed7b8
Compare
s-todorova
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
GerganaKremenska
requested changes
Jun 10, 2026
GerganaKremenska
left a comment
GerganaKremenska
left a comment
Contributor
There was a problem hiding this comment.
CSS leftover --ui5_dialog_header_focus* and --_ui5_dialog_header_border_radius in base/ Dialog-parameters.less, sap_horizon/Dialog-parameters.less, sap_horizon_dark/Dialog-parameters.less
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
TeodorTaushanov
requested changes
Jun 17, 2026
TeodorTaushanov
left a comment
TeodorTaushanov
left a comment
Member
There was a problem hiding this comment.
Using Shift + Tab to navigate focus doesn’t cycle through the entire dialog. Using only Tab is ok.
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
TeodorTaushanov
approved these changes
Jun 19, 2026
s-todorova
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🧹 Preview deployment cleaned up: https://pr-13632--ui5-webcomponents.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRODOPI-3659