defaultState is now declared as a getter in the declaration file#409
Merged
Conversation
Pull Request Test Coverage Report for Build 2832464441
💛 - Coveralls |
Contributor
Author
|
Thanks for merging it Andrea, very much appreciated! 🙏 |
Owner
|
@yuretz apologies I'm on vacation it took your reminder to remind me to do that ... which I did now 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny change to the .d.ts file that solves the issue described here with
defaultStatenot being declared exactly the same way it was implemented and upsetting the type checker when e.g. overridden in a class derived from theComponent.get/set declarations in
d.tsfiles should be supported since 3.6 release of TypeScript, which was 3 years ago. So, while in theory someone using hyperHTML with an older TS version is most likely to get unexpected type checking errors because of this change, but in practice there wouldn't be many people like this, I assume. I don't quite know what's your policy regarding breaking changes in the type declarations file, but now you know about it's potential effect.Maybe TS compatibility warrants a note in the Readme somewhere, what do you think?