Handle NPM prerelease caret range expression #120
Merged
Merged
Conversation
keshav-space
commented
Sep 4, 2023
keshav-space
commented
Member
- fixes NpmVeresionRange is giving incorrect version range sequence for prerelease caret range #117
keshav-space
force-pushed
the
117-fix-npm-caret-range
branch
from
51b8556 to
865dc05
Compare
Contributor
|
@keshav-space LGTM! please add some context in commit messages to highlight why we are handling the caret expression in a special manner. |
- Don't use `python-semanticversion` for parsing the npm caret range:
it's returning incorrect vers range for the prerelease caret range expressions.
- Issue #117
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
keshav-space
force-pushed
the
117-fix-npm-caret-range
branch
from
865dc05 to
da287b1
Compare
Member
Author
Thanks @TG1999, I have added the context along with the link to the original issue in the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.