Skip to content

add context menu#33

Merged
mbuchetics merged 5 commits into
masterfrom
add-context-menu
Sep 10, 2020
Merged

add context menu#33
mbuchetics merged 5 commits into
masterfrom
add-context-menu

Conversation

@vuln3r

@vuln3r vuln3r commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sandin added 2 commits September 3, 2020 11:54
- add differ via spm to the last version
@vuln3r vuln3r self-assigned this Sep 3, 2020
@vuln3r vuln3r requested a review from draskovits September 3, 2020 15:20
# Conflicts:
#	DataSource.xcodeproj/project.pbxproj
@mbuchetics

Copy link
Copy Markdown
Contributor

Thanks!
Two things:

  1. in future PRs, please don't re-format the code, this makes it hard to code review. Please open a separate PR in such a case. It's ok for now, but please take it into account in the future.

  2. do not use an existing example to show off new functionality, add a new example.

@vuln3r

vuln3r commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

Thanks!
Two things:

  1. in future PRs, please don't re-format the code, this makes it hard to code review. Please open a separate PR in such a case. It's ok for now, but please take it into account in the future.
  2. do not use an existing example to show off new functionality, add a new example.
  1. Sorry, it was automatically ...
  2. It was only for internal showing purposes after approving I wanted to create the example just for that

@mbuchetics mbuchetics requested review from mbuchetics and removed request for draskovits September 9, 2020 07:43

@mbuchetics mbuchetics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the example code, then it's fine to merge 👍

@vuln3r vuln3r requested a review from mbuchetics September 9, 2020 14:50
@mbuchetics mbuchetics merged commit faf6e4b into master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants