Add support for async NUnit tests#314
Merged
Merged
Conversation
Contributor
|
Hello, @overlord ! Looks like it solves this issue completely. |
neparij
suggested changes
Dec 29, 2022
neparij
left a comment
Contributor
There was a problem hiding this comment.
Nice solution, could you look at review?
undron
reviewed
Dec 29, 2022
230e593 to
a90882d
Compare
a90882d to
c0fd75e
Compare
neparij
suggested changes
Dec 30, 2022
neparij
left a comment
Contributor
There was a problem hiding this comment.
Remove accidentally added file please.
| @@ -0,0 +1,24 @@ | |||
| # EditorConfig is awesome: http://EditorConfig.org | |||
neparij
approved these changes
Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request provides workaround or maybe even fixes the issues (in
Allure.NUnit 2.9.2-preview.1) with async test methods in NUnit.Allure.It fixes the case when async methods marked with
[AllureStep]like the following:fails in runtime with exception like the following:
The main problem was in the ThreadStatic field
AllureStorage.stepContext- that fails on cross-thread execution of async methods.I have tried to fix it and have provided some unit tests for new async behaviour (see.
Allure.NUnit.AsyncTests.AsyncLifeCycleTests)