Allow SpecFlow to continue even if Harmony patch fails#437
Merged
Conversation
neparij
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436
Context
This PR allows a SpecFlow test run to continue if Harmony patching fails (e.g., for net8.0, see #434).
Ideally, a warning should've been logged, but no such API exists in SpecFlow. The best I came up with was to log the last exception in a file in the output directory.
Motivation
The main motivation is to enable users who don't need selective run feature to use Allure SpecFlow with net8.0 until the MonoMod fix for net8.0 is released.