Support MSBuild extension files in sample projects when referencing projects under test via ProjectReference#666
Open
delatrie wants to merge 2 commits into
Open
Support MSBuild extension files in sample projects when referencing projects under test via ProjectReference#666delatrie wants to merge 2 commits into
delatrie wants to merge 2 commits into
Conversation
delatrie
added
the
type:internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The PR adds support for automatically importing MSBuild extension files
buildandbuildTransitivein generated sample projects when they reference projects under test directly (i.e., viaProjectReference).Directory.Build.propsDirectory.Build.targets_PackageFilesitems returned by the_GetPackageFilestarget. The files can be stored anywhere and called anything as long as they are correctly mapped to one of the following locations via thePackagePath:/build/<ProjectName>.props/build/<ProjectName>.targets/buildTransitive/<ProjectName>.props/buildTransitive/<ProjectName>.targets/buildare only imported for the direct references.When projects under test are referenced as packages (via
PackageReference), no extra support is required as NuGet imports these extensions for us.This is a prerequisite for implementing integration tests for xunit.v3 and MTP adapters. Without it, we would be required to pack the target projects each time we test them, which would increase the dev loop and require cleaning the NuGet cache.
Checklist