Ability to change logging behavior#69
Merged
Merged
Conversation
Owner
|
lgtm, thanks! |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using UnityHTTP for some time now, and have found one feature very helpful: the ability to change logging behavior.
This PR introduces 3 different logging behaviors:
UnityLogger(prints to Unity console),ConsoleLogger(prints to System.Console) andDiscardLogger(discards logs without actually printing anything).The loggers can be set per each request, default logger is stored in
Request.Logger.The default behavior wasn't changed, I even left some of the #defines in place to maintain 100% char-to-char backwards compatibility.