Skip to content

feat(core): add ng generate schematic to remove unnecessary modules #48832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crisbeto wants to merge 2 commits into from
Closed

feat(core): add ng generate schematic to remove unnecessary modules #48832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
504aca5
feat(core): add ng generate schematic to remove unnecessary modules
crisbeto Jan 25, 2023
ceef40c
fixup! feat(core): add ng generate schematic to remove unnecessary mo…
crisbeto Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/core/schematics/ng-generate/standalone-migration/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@ import ts from 'typescript';
import {getProjectTsConfigPaths} from '../../utils/project_tsconfig_paths';
import {canMigrateFile, createProgramOptions} from '../../utils/typescript/compiler_host';

import {pruneNgModules} from './prune-modules';
import {toStandalone} from './to-standalone';
import {ChangesByFile} from './util';

enum MigrationMode {
toStandalone = 'convert-to-standalone',
pruneModules = 'prune-ng-modules',
}

interface Options {
Expand Down Expand Up @@ -75,15 +77,25 @@ function standaloneMigration(tree: Tree, tsconfigPath: string, basePath: string,
}

let pendingChanges: ChangesByFile;
let filesToRemove: Set<ts.SourceFile>|null = null;

if (options.mode === MigrationMode.toStandalone) {
pendingChanges = toStandalone(sourceFiles, program, printer);
} else if (options.mode === MigrationMode.pruneModules) {
const result = pruneNgModules(program, host, basePath, rootNames, sourceFiles, printer);
pendingChanges = result.pendingChanges;
filesToRemove = result.filesToRemove;
} else {
throw new SchematicsException(
`Unknown schematic mode ${options.mode}. Cannot run the standalone migration.`);
}

for (const [file, changes] of pendingChanges.entries()) {
// Don't attempt to edit a file if it's going to be deleted.
if (filesToRemove?.has(file)) {
continue;
}

const update = tree.beginUpdate(relative(basePath, file.fileName));

changes.forEach(change => {
Expand All @@ -95,4 +107,10 @@ function standaloneMigration(tree: Tree, tsconfigPath: string, basePath: string,

tree.commitUpdate(update);
}

if (filesToRemove) {
for (const file of filesToRemove) {
tree.delete(relative(basePath, file.fileName));
}
}
}
Loading