Skip to content

fix(migrations): add enum in mode option in standalone schema #48851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 wants to merge 3 commits into from
Closed

fix(migrations): add enum in mode option in standalone schema #48851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ca12ee
fix(migrations): add `enum` in `mode` option in `standalone` schema
alan-agius4 Jan 26, 2023
d365dac
fixup! fix(migrations): add `enum` in `mode` option in `standalone` s…
alan-agius4 Jan 26, 2023
27fe84c
fixup! fix(migrations): add `enum` in `mode` option in `standalone` s…
alan-agius4 Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/core/schematics/ng-generate/standalone-migration/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,13 @@ function standaloneMigration(tree: Tree, tsconfigPath: string, basePath: string,
let pendingChanges: ChangesByFile;
let filesToRemove: Set<ts.SourceFile>|null = null;

if (options.mode === MigrationMode.toStandalone) {
pendingChanges = toStandalone(sourceFiles, program, printer);
} else if (options.mode === MigrationMode.pruneModules) {
if (options.mode === MigrationMode.pruneModules) {
const result = pruneNgModules(program, host, basePath, rootNames, sourceFiles, printer);
Comment thread
alan-agius4 marked this conversation as resolved.
Outdated
pendingChanges = result.pendingChanges;
filesToRemove = result.filesToRemove;
} else {
throw new SchematicsException(
`Unknown schematic mode ${options.mode}. Cannot run the standalone migration.`);
/** MigrationMode.toStandalone */
pendingChanges = toStandalone(sourceFiles, program, printer);
}

for (const [file, changes] of pendingChanges.entries()) {
Expand Down
1 change: 1 addition & 0 deletions packages/core/schematics/ng-generate/standalone-migration/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"mode": {
"description": "Operation that should be performed by the migrator",
"type": "string",
"enum": ["convert-to-standalone", "prune-ng-modules"],
Comment thread
alan-agius4 marked this conversation as resolved.
Outdated
"default": "convert-to-standalone",
"x-prompt": {
"message": "Choose the type of migration:",
Expand Down
15 changes: 0 additions & 15 deletions packages/core/schematics/test/standalone_migration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,21 +178,6 @@ describe('standalone migration', () => {
expect(error).toBe('Cannot run standalone migration outside of the current project.');
});

it('should throw an error if an unknown mode is passed in', async () => {
let error: string|null = null;

writeFile('dir.ts', 'console.log(123)');

try {
await runMigration('does-not-exist', './');
} catch (e: any) {
error = e.message;
}

expect(error).toBe(
'Unknown schematic mode does-not-exist. Cannot run the standalone migration.');
});

it('should throw an error if the passed in path is a file', async () => {
let error: string|null = null;

Expand Down