Skip to content

[19.2.x] Cherry-pick security and bug fixes#68939

Merged
alxhub merged 3 commits into
angular:19.2.xfrom
alan-agius4:cherry-pick-to-19.2.x
May 27, 2026
Merged

[19.2.x] Cherry-pick security and bug fixes#68939
alxhub merged 3 commits into
angular:19.2.xfrom
alan-agius4:cherry-pick-to-19.2.x

Conversation

@alan-agius4

Copy link
Copy Markdown
Contributor

This PR backports a batch of security and critical bug & security fixes to the 19.2.x branch:

All golden symbols files have been regenerated and verified, and all conflicts have been resolved cleanly to align with the core architectures of the 19.2.x branch.

@angular-robot angular-robot Bot added area: common/http Issues related to HTTP and HTTP Client area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels May 27, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 27, 2026
@angular-robot angular-robot Bot added the area: server Issues related to server-side rendering label May 27, 2026
@alan-agius4 alan-agius4 requested a review from JeanMeche May 27, 2026 07:26
@angular-robot angular-robot Bot added the area: service-worker Issues related to the @angular/service-worker package label May 27, 2026
@alan-agius4 alan-agius4 added target: lts This PR is targeting a version currently in long-term support action: review The PR is still awaiting reviews from at least one requested reviewer PullApprove: disable and removed area: service-worker Issues related to the @angular/service-worker package labels May 27, 2026
@alan-agius4 alan-agius4 force-pushed the cherry-pick-to-19.2.x branch from 3762052 to 7dab3e3 Compare May 27, 2026 07:33
@angular-robot angular-robot Bot added the area: service-worker Issues related to the @angular/service-worker package label May 27, 2026
@alan-agius4 alan-agius4 force-pushed the cherry-pick-to-19.2.x branch from 64ead5b to d31f841 Compare May 27, 2026 08:13
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 27, 2026
@alan-agius4 alan-agius4 force-pushed the cherry-pick-to-19.2.x branch 4 times, most recently from 32426f1 to 16ac73d Compare May 27, 2026 10:37
@alan-agius4 alan-agius4 force-pushed the cherry-pick-to-19.2.x branch from 16ac73d to d31f841 Compare May 27, 2026 10:50
@alan-agius4 alan-agius4 reopened this May 27, 2026
@alan-agius4 alan-agius4 force-pushed the cherry-pick-to-19.2.x branch 2 times, most recently from bdf155a to aecaa96 Compare May 27, 2026 11:44
…g tag check

This ensures that when rootElement is undefined no error occures.
@alan-agius4 alan-agius4 force-pushed the cherry-pick-to-19.2.x branch from 6061c09 to 74c4a8b Compare May 27, 2026 12:52
@alan-agius4 alan-agius4 force-pushed the cherry-pick-to-19.2.x branch from 74c4a8b to 2413202 Compare May 27, 2026 13:02
…inst SSRF and path hijack

Normalizes the URL and path parsing logic inside platform-server by consolidating security checks and normalizations into a single, unified parseUrl helper function.

This includes:
- Collapsing multiple consecutive leading slashes and backslashes (e.g., // or /\) to a single forward slash to avoid protocol-relative parsing of path-like & relative inputs.
- Rejecting malformed absolute URLs that are otherwise accepted by lenient DOM parsers like Domino but rejected by standard WHATWG parsers, preventing SSRF / allowedHosts validation bypasses.
- Ensuring parseDocument gets the fully parsed and normalized URL instead of raw, unvalidated configuration values, preventing virtual document hostname adoption/origin hijack.
- Moving parseUrl unit tests into a dedicated url_spec.ts test file to keep platform_location_spec.ts clean and decoupled.
@alan-agius4 alan-agius4 added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 27, 2026
@alan-agius4

Copy link
Copy Markdown
Contributor Author

caretaker note kindly ignore the pending mergeability tests.

@alxhub alxhub merged commit c75f60e into angular:19.2.x May 27, 2026
24 of 27 checks passed
@alxhub

alxhub commented May 27, 2026

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime area: server Issues related to server-side rendering area: service-worker Issues related to the @angular/service-worker package merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants