FINERACT-2455: Add loan origination support to working capital loans#5971
Conversation
c02872e to
d897083
Compare
|
@Cocoa-Puffs Please review the failing checks |
b1fab89 to
80f3b2f
Compare
02cffff to
0ec8a04
Compare
0ec8a04 to
4cab072
Compare
88154b6 to
063f7d9
Compare
|
Things to be considered Doc/permission mismatch (should fix). The WC attach/detach @operation descriptions say "Requires ATTACH_LOAN_ORIGINATOR / DETACH_LOAN_ORIGINATOR permission", but the command entity is WORKING_CAPITAL_LOAN_ORIGINATOR and the migration seeds ATTACH_WORKING_CAPITAL_LOAN_ORIGINATOR / DETACH_WORKING_CAPITAL_LOAN_ORIGINATOR. The Swagger text is a stale copy-paste and will mislead API consumers about which permission to grant. Module placement inconsistency (worth a look). WorkingCapitalLoanOriginatorMapping, its repository, and WorkingCapitalLoanOriginatorMappingNotFoundException live in the loanorigination module, while every other WC originator class (services, handlers, API resource, the not-in-submitted-status exception) lives in the workingcapitalloan module. These WC-specific classes only reference loan_id as a plain Long, so nothing forces them into the origination module — placing them with the rest of the WC code would be more consistent with how the feature is otherwise split. |
b55352e to
d624540
Compare
I have moved everything I could into the originators module. some things stayed because they depend on wc module content. WorkingCapitalLoanOriginatorsApiResource.java — depends on WorkingCapitalLoanConstants, WorkingCapitalLoanNotFoundException, and WorkingCapitalLoanApplicationReadPlatformService (all WC module). Cannot move. WorkingCapitalLoanOriginatorWritePlatformService.java — depends on WorkingCapitalLoan, WorkingCapitalLoanRepository, and WorkingCapitalLoanNotFoundException (all WC module). Cannot move. AttachWorkingCapitalLoanOriginatorCommandHandler.java — depends on WorkingCapitalLoanOriginatorWritePlatformService (WC module). Cannot move. DetachWorkingCapitalLoanOriginatorCommandHandler.java — same as above. Cannot move. Other than these newly created files the other are in the originators module. |
|
@Cocoa-Puffs Please rebase. |
3ff2b3a to
4a39e92
Compare
4a39e92 to
b91a327
Compare
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.