Skip to content

Add support for dameng(DM) JDBC URL format in URLParser #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 8 commits into from
Jun 10, 2025
Merged

Add support for dameng(DM) JDBC URL format in URLParser #758

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7558d73
[Feature] Add URLParser for dameng(DM)
saber-wang Jun 9, 2025
99455ee
update CHANGES
saber-wang Jun 9, 2025
e6e5201
Clean up comments
saber-wang Jun 9, 2025
74718b0
update DMDB_JDBC_DRIVER Component id
saber-wang Jun 9, 2025
359f373
Remove DM logo
saber-wang Jun 9, 2025
5411c3a
Revert "Remove DM logo"
saber-wang Jun 10, 2025
e149915
Update description
saber-wang Jun 10, 2025
a2cc314
CHANGES.md
wu-sheng Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up comments
  • Loading branch information
@saber-wang
saber-wang committed Jun 9, 2025
commit e6e5201821ecd80b2783ae20d3849227d1fc181a
6 changes: 1 addition & 5 deletions ...src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/DMURLParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public DMURLParser(String url) {
protected URLLocation fetchDatabaseHostsIndexRange() {
int hostLabelStartIndex = url.indexOf("//");
if (hostLabelStartIndex == -1) {
return new URLLocation(0, 0); // 格式错误
return new URLLocation(0, 0);
}
int hostLabelEndIndex = url.indexOf("?", hostLabelStartIndex + 2);
if (hostLabelEndIndex == -1) {
Expand Down Expand Up @@ -71,7 +71,6 @@ public ConnectionInfo parse() {
}
}

// 如果 host 或 port 没有从路径中获取到，则尝试从参数中获取
if (host.isEmpty()) {
host = fetchFromUrlParams(URL_PARAMS_HOST_KEY);
}
Expand All @@ -94,9 +93,6 @@ public ConnectionInfo parse() {
);
}

/**
* 从 URL 参数中提取指定 key 的值
*/
private String fetchFromUrlParams(String key) {
int paramIndex = url.indexOf("?");
if (paramIndex == -1) {
Expand Down
Loading