Skip to content

feat: Added optional location speed attribute for android devices#594

Merged
mykola-mokhnach merged 3 commits into
appium:masterfrom
salabogdan:CustomLocationSpeed
Mar 10, 2021
Merged

feat: Added optional location speed attribute for android devices#594
mykola-mokhnach merged 3 commits into
appium:masterfrom
salabogdan:CustomLocationSpeed

Conversation

@salabogdan

@salabogdan salabogdan commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

Added location speed attribute. This enables testing of android applications that require mock locations having valid speed reported.
This is related to:

Comment thread appium/webdriver/extensions/location.py Outdated
Comment thread appium/webdriver/extensions/location.py Outdated
@mykola-mokhnach

Copy link
Copy Markdown
Contributor

Please sign the CLA

@salabogdan

salabogdan commented Mar 5, 2021

Copy link
Copy Markdown
Contributor Author

Please sign the CLA

I clicked on details i already agreed to the license and I can not do anything more there.
Screenshot 2021-03-05 at 20 27 02

@mykola-mokhnach

Copy link
Copy Markdown
Contributor

Make sure the correct email address is set for your local github account

@salabogdan salabogdan force-pushed the CustomLocationSpeed branch from 921486f to 4cfc91d Compare March 5, 2021 21:42
@salabogdan salabogdan changed the title feat!: Added optional location speed attribute for android devices feat: Added optional location speed attribute for android devices Mar 5, 2021
Comment thread appium/webdriver/extensions/location.py Outdated
@salabogdan

Copy link
Copy Markdown
Contributor Author

Can you help with some suggestions i have seen that the appium.python-client check is failing and i am not sure what is the reason?

@salabogdan

Copy link
Copy Markdown
Contributor Author

@mykola-mokhnach what can i do to move this forward?

@mykola-mokhnach mykola-mokhnach merged commit ce78c0d into appium:master Mar 10, 2021
@florinflorian

florinflorian commented Mar 11, 2021

Copy link
Copy Markdown

Hello guys. This improvement would be useful. Do you have any plans on releasing this immediately?
@mykola-mokhnach

@KazuCocoa

Copy link
Copy Markdown
Member

Released as 1.1.0

@florinflorian

florinflorian commented Mar 12, 2021

Copy link
Copy Markdown

@KazuCocoa thanks.
@mykola-mokhnach What about full release for appium desktop client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants