Skip to content

Replace manual casts with new instanceof expression syntax#774

Merged
ascopes merged 1 commit into
v5from
task/v5-use-instanceof-improvements
Dec 28, 2024
Merged

Replace manual casts with new instanceof expression syntax#774
ascopes merged 1 commit into
v5from
task/v5-use-instanceof-improvements

Conversation

@ascopes

@ascopes ascopes commented Dec 28, 2024

Copy link
Copy Markdown
Owner

No description provided.

@ascopes ascopes added the enhancement Optimisations and internal improvements in the codebase. label Dec 28, 2024
@ascopes ascopes self-assigned this Dec 28, 2024
@codecov

codecov Bot commented Dec 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.16%. Comparing base (0dedcda) to head (e0717e9).
Report is 1 commits behind head on v5.

Files with missing lines Patch % Lines
.../jct/containers/impl/ModuleContainerGroupImpl.java 0.00% 2 Missing ⚠️
.../jct/workspaces/impl/AbstractManagedDirectory.java 0.00% 2 Missing ⚠️
...hub/ascopes/jct/workspaces/impl/WorkspaceImpl.java 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v5     #774      +/-   ##
==========================================
- Coverage   87.17%   87.16%   -0.01%     
==========================================
  Files          99       99              
  Lines        2932     2922      -10     
  Branches      229      230       +1     
==========================================
- Hits         2556     2547       -9     
+ Misses        329      328       -1     
  Partials       47       47              
Files with missing lines Coverage Δ
.../containers/impl/ContainerGroupRepositoryImpl.java 59.68% <100.00%> (-0.92%) ⬇️
...ithub/ascopes/jct/filemanagers/ModuleLocation.java 100.00% <100.00%> (ø)
...opes/jct/filemanagers/impl/JctFileManagerImpl.java 100.00% <100.00%> (ø)
...opes/jct/filemanagers/impl/PathFileObjectImpl.java 100.00% <100.00%> (ø)
...b/ascopes/jct/junit/AbstractCompilersProvider.java 100.00% <100.00%> (ø)
.../io/github/ascopes/jct/utils/ModuleDiscoverer.java 100.00% <100.00%> (ø)
...a/io/github/ascopes/jct/utils/ToStringBuilder.java 100.00% <100.00%> (ø)
...pes/jct/workspaces/impl/WrappingDirectoryImpl.java 85.18% <100.00%> (ø)
...hub/ascopes/jct/workspaces/impl/WorkspaceImpl.java 39.77% <66.66%> (+0.44%) ⬆️
.../jct/containers/impl/ModuleContainerGroupImpl.java 22.22% <0.00%> (ø)
... and 1 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Optimisations and internal improvements in the codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant