Skip to content

Add flake8 step to circleci container. Fix pep8 errors of project#154

Closed
skatsaounis wants to merge 1 commit into
auth0:masterfrom
skatsaounis:master
Closed

Add flake8 step to circleci container. Fix pep8 errors of project#154
skatsaounis wants to merge 1 commit into
auth0:masterfrom
skatsaounis:master

Conversation

@skatsaounis

Copy link
Copy Markdown

The title says it all.

This pr adds one more step to circle ci python 2.7 container to run flake8 for pep8 compliance errors.

Furthermore, it fixes all pep8 errors of repo.

@lbalmaceda

Copy link
Copy Markdown
Contributor

@skatsaounis I don't see why this needs to be added as part of our CI build. That's continuous integration, not continuous deployment. The result of running this command on the CI will be lost.

Different would be if this is added as a pre-commit hook so that anyone adding a new git commit would be forced to run this before that. If you manage to do that I'll happily review the PR again. That said, why have you ignored the following 2 issues? They seem correct:

@skatsaounis

Copy link
Copy Markdown
Author

Hi @lbalmaceda,

Thank you for looking into my PR.

I will look into pre commit hook but I have never done it before so a link would be useful to try that out.

As far as these two rules are concerned:

  • E123: is invalid rule for PEP8. You can have a look at the bottom of the intentation where an example exists with my_list variable
  • E125: After I change it to E129, because I just found that the erroneous case was separated, then it can be ignored. You can have a look here and here

@joshcanhelp joshcanhelp mentioned this pull request Oct 26, 2018
@joshcanhelp

Copy link
Copy Markdown
Contributor

We appreciate the effort here but I think this PR is going to age poorly as we merge in other PRs. Definitely open to discussing again at some point but going to close this for now.

@joshcanhelp joshcanhelp closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants