Add flake8 step to circleci container. Fix pep8 errors of project#154
Add flake8 step to circleci container. Fix pep8 errors of project#154skatsaounis wants to merge 1 commit into
Conversation
|
@skatsaounis I don't see why this needs to be added as part of our CI build. That's continuous integration, not continuous deployment. The result of running this command on the CI will be lost. Different would be if this is added as a pre-commit hook so that anyone adding a new git commit would be forced to run this before that. If you manage to do that I'll happily review the PR again. That said, why have you ignored the following 2 issues? They seem correct: |
|
Hi @lbalmaceda, Thank you for looking into my PR. I will look into pre commit hook but I have never done it before so a link would be useful to try that out. As far as these two rules are concerned:
|
|
We appreciate the effort here but I think this PR is going to age poorly as we merge in other PRs. Definitely open to discussing again at some point but going to close this for now. |
The title says it all.
This pr adds one more step to circle ci python 2.7 container to run flake8 for pep8 compliance errors.
Furthermore, it fixes all pep8 errors of repo.