README improvements#239
Merged
Merged
Conversation
Follow-up to bazel-contrib#237. Moves development workflow info to CONTRIBUTING.md. Fixes the instructions for how to use the Bazel Federation. Also updates the project WORKSPACE to use a released version of the Federation.
Merged
Contributor
Author
|
Ping @laurentlb |
Contributor
Author
|
Adding @fweikert since aiuto is on vacation. Florian, this is just a readme update that happens to include some fixes for the federation, so I figured you could vet the federation content ("Getting started" section) and rubber stamp the rest. |
fweikert
suggested changes
Oct 18, 2019
fweikert
approved these changes
Oct 18, 2019
fweikert
left a comment
fweikert
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the federation-related parts
Contributor
Author
|
I'll merge this. Laurent, feel free to request changes in a follow-up. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #237. Moves development workflow info to CONTRIBUTING.md. Fixes
the instructions for how to use the Bazel Federation.
Also updates the project WORKSPACE to use a released version of the Federation.