fix(pypi): respect empty envsubst expansion in experimental_index_url#3828
Conversation
kriscfoster
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates envsubst into hub_builder.bzl to resolve the experimental index URL, allowing environment variables to be substituted properly. It also adds corresponding regression tests. A critical issue was identified where module_ctx does not have a getenv method (it should be module_ctx.os.environ.get), and pip_attr.experimental_index_url could be None, which would cause a crash in envsubst.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2 participants
Resolve
pip.parse(experimental_index_url = ...)throughenvsubstbefore checking whether the experimental index-url code path should be
enabled.
Previously, an unsubstituted template like
$RULES_PYTHON_PIP_INDEX_URLis a non-empty string and thereforetruthy, so
_set_get_index_urlsenabled the experimental index-urlmode even when the env var was unset or expanded to empty.
With this change, the value is expanded first (using
pip_attr.envsubstand
module_ctx.os.environ.get) and the truthiness check runs againstthe resolved string, matching the behavior users expect when they gate
the index URL on an env var.