Swift app#1
Merged
Merged
Conversation
NouamaneTazi
requested changes
May 16, 2023
NouamaneTazi
left a comment
NouamaneTazi
left a comment
Collaborator
There was a problem hiding this comment.
Very clean! One minor comment before we can merge this awesomeness
Collaborator
There was a problem hiding this comment.
Is this icon still used?
Contributor
Author
There was a problem hiding this comment.
It's a placeholder until I can get a StarCoder version :) Slack comment [internal]: https://huggingface.slack.com/archives/C031GD0V5S5/p1684176403377149?thread_ts=1683292595.926539&cid=C031GD0V5S5
NouamaneTazi
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate.cppis a copy ofmain.cppwith some modifications necessary for a better experience:Ideally we should merge those files and keep just one copy that supports both the command-line and the app use cases. We can do that in a followup PR.
Generation is using default parameters.