Conversation
| except ImportError: | ||
| __path__ = __import__('pkgutil').extend_path(__path__, __name__) |
There was a problem hiding this comment.
According to these docs (https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages) [See the note at the end of the page] it seems that this is not needed, and it is not advisable.
The idea behind this was that in the rare case that setuptools isn’t available packages would fall-back to the pkgutil-style packages. This isn’t advisable because pkgutil and pkg_resources-style namespace packages are not cross-compatible. If the presence of setuptools is a concern then the package should just explicitly depend on setuptools via install_requires.
There was a problem hiding this comment.
I tried to remove it, and I could install both libraries without any problem with Python2 and Python3. It will only be a problem if setuptools is not installed. It would be a very uncommon case...
|
We are using pkg_resources-style namespace packages. See comments in chronos PR to get more info. |
|
Closing this PR and opening another one to cherry-pick the commits that extend the ability to use an alternate URL for predictions. |
2 participants
No description provided.