fix: display and resize plots when not in a lumino context#1531
Merged
martinRenou merged 2 commits intoMar 21, 2023
Merged
Conversation
9 tasks
This was referenced Oct 26, 2022
Member
|
See also jupyter-widgets/ipywidgets#3282 |
This was referenced Jan 6, 2023
This was referenced Jan 15, 2023
d4e0958 to
0f05a17
Compare
0f05a17 to
7d4ce2e
Compare
Member
|
I guess we need to limit yarn, see #1588 (comment) |
c1825bb to
c45826c
Compare
Member
|
meeseeksdev please backport to 0.12.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
martinRenou
pushed a commit
to martinRenou/bqplot
that referenced
this pull request
Mar 21, 2023
* fix: display and resize plots when not in a lumino context * chore: fix CI (cherry picked from commit 55d660d)
martinRenou
pushed a commit
to martinRenou/bqplot
that referenced
this pull request
Mar 21, 2023
* fix: display and resize plots when not in a lumino context * chore: fix CI (cherry picked from commit 55d660d)
martinRenou
pushed a commit
to martinRenou/bqplot
that referenced
this pull request
Mar 21, 2023
* fix: display and resize plots when not in a lumino context * chore: fix CI (cherry picked from commit 55d660d)
martinRenou
pushed a commit
to martinRenou/bqplot
that referenced
this pull request
Mar 21, 2023
* fix: display and resize plots when not in a lumino context * chore: fix CI (cherry picked from commit 55d660d)
martinRenou
added a commit
that referenced
this pull request
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
no issue for this yet
Code changes
Use a combination of
IntersectionObserverandResizeObserverinstead of lumino-events to control relayouts, so this works when lumino-events are not available. This is the case when embedding bqplot in an ipyvuetify-template.The typescript version was changed to have type support for ResizeObserver.
User-facing changes
before:
before.mp4
after:
after.mp4
To reproduce:
A similar PR, but without resize support: #1029