fix(langgraph): unblock release — empty-stream mock fails lint#690
Merged
Conversation
The construction-only test stub used an empty async generator
`(async function* () {})()` which @typescript-eslint/no-empty-function
flags as an error, breaking `langgraph:lint` in the publish path (which
lints fresh via --skip-nx-cache). Document the empty body so the rule
passes; behaviour is unchanged (still yields no events).
Surfaced by a release dry-run; not caught at merge because ci.yml lint
is not a required status check.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A release dry-run (
Publishworkflow, dry-run mode) failed atlanggraph:lint:The construction-only test stub used
(async function* () {})(). The rule flags the empty body as an error, which fails the publish path's fresh lint (--skip-nx-cache). Normal CI was green becauseci.ymllint runs cached and isn't a required status check, so the error reachedmain(via #681).Fix documents the empty generator body so the rule passes — behaviour unchanged (still yields no events).
Test Plan
npx nx lint langgraph --skip-nx-cache→ passes (was failing)🤖 Generated with Claude Code