Fix the fifth week's test referencing nonexistent attribute on list#88
Closed
emreozcan wants to merge 0 commit into
Closed
Fix the fifth week's test referencing nonexistent attribute on list#88emreozcan wants to merge 0 commit into
emreozcan wants to merge 0 commit into
Conversation
canbula
reviewed
Mar 14, 2024
canbula
left a comment
Owner
There was a problem hiding this comment.
You have a good point Emre, however, the test here implies that you need to have a property in your class with the name data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The test tries to access the "data" attribute of an Emails object, which is supposed to be a subclass of list. Then, the test tries to access a "count" attribute, an actual attribute of list.
This led me to believe that the "data" access was mistakenly added. This patch removes the intermediary access to data and replaces
with
Checklist
Screenshots (if appropriate)