Skip to content

Fix the fifth week's test referencing nonexistent attribute on list#88

Closed
emreozcan wants to merge 0 commit into
canbula:masterfrom
emreozcan:master
Closed

Fix the fifth week's test referencing nonexistent attribute on list#88
emreozcan wants to merge 0 commit into
canbula:masterfrom
emreozcan:master

Conversation

@emreozcan

Copy link
Copy Markdown
Contributor

Describe your changes

The test tries to access the "data" attribute of an Emails object, which is supposed to be a subclass of list. Then, the test tries to access a "count" attribute, an actual attribute of list.

This led me to believe that the "data" access was mistakenly added. This patch removes the intermediary access to data and replaces

Emails(...).data.count(...)

with

Emails(...).count(...)

Checklist

  • I have read the [CONTRIBUTING]
  • I have performed a self-review of my own code
  • I have run the code locally and it works as expected
  • I have commented my code, particularly in hard-to-understand areas

Screenshots (if appropriate)

@canbula canbula left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a good point Emre, however, the test here implies that you need to have a property in your class with the name data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants