Skip to content

Allow Symfony 7#203

Closed
tacman wants to merge 1 commit into
cebe:masterfrom
tacman:patch-1
Closed

Allow Symfony 7#203
tacman wants to merge 1 commit into
cebe:masterfrom
tacman:patch-1

Conversation

@tacman

@tacman tacman commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@tacman

tacman commented Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

any downside to merging this?

@cebe cebe mentioned this pull request Nov 13, 2024
@cebe

cebe commented Nov 13, 2024

Copy link
Copy Markdown
Owner

Tests are failing on php 8.2 #212

@tacman

tacman commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

yes, but that's not related to Symfony 7, is it?

@tacman

tacman commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

Personally, I'd prefer to see all unsupported versions of Symfony dropped. So ^5.4, ^6.4, ^7

If it's a new release, I'd even say just ^6.4 || ^7, since 5.4 is near EOL

@tacman tacman mentioned this pull request Nov 14, 2024
@cebe cebe added this to the 1.8.0 milestone Nov 14, 2024
@cebe

cebe commented Nov 14, 2024

Copy link
Copy Markdown
Owner

yes, but that's not related to Symfony 7, is it?

I did not know whether it's related or not so I wanted to wait for tests to pass.

Personally, I'd prefer to see all unsupported versions of Symfony dropped. So ^5.4, ^6.4, ^7

what's the point in dropping versions that work fine, breaking someones code? Dropping old versions is fine if it is complicated to support these. For Symfony YAML I'd keep it as widely compatibly as possible.

@cebe

cebe commented Nov 14, 2024

Copy link
Copy Markdown
Owner

Your commit is merged in #212, thanks!

@cebe cebe closed this Nov 14, 2024
@prajapati-kaushik

Copy link
Copy Markdown

@cebe: I suppose, brach merged but a new version 7.1 release is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants