Skip to content

PHP8 support#83

Merged
cebe merged 1 commit into
cebe:masterfrom
canvural:php8
Dec 15, 2020
Merged

PHP8 support#83
cebe merged 1 commit into
cebe:masterfrom
canvural:php8

Conversation

@canvural

Copy link
Copy Markdown
Contributor

This PR:

  • Fixes Support PHP 8 #81
  • Removes php-cs-fixer from composer.json and downloads phar on launch
  • Fixes deprecated PHPUnit methods

Comment thread Makefile Outdated
cp $< $@

php-cs-fixer.phar:
wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.16.7/php-cs-fixer.phar && chmod 777 php-cs-fixer.phar

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.16.7/php-cs-fixer.phar && chmod 777 php-cs-fixer.phar
wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.16.7/php-cs-fixer.phar && chmod +x php-cs-fixer.phar

@cebe cebe added this to the 1.5.0 milestone Dec 14, 2020
@cebe

cebe commented Dec 14, 2020

Copy link
Copy Markdown
Owner

Thanks for these changes. Tests are failing, seems there is another case related to assertInternalType() method. Do you have the time to fix these?

@cebe cebe self-assigned this Dec 14, 2020
@cebe cebe mentioned this pull request Dec 14, 2020
@canvural

canvural commented Dec 14, 2020

Copy link
Copy Markdown
Contributor Author

@cebe Updated the PR 👍 Locally tests are failing for ReferenceTest::testTransitiveReferenceOverTwoFiles But I'm thinking this is because of the latest changes to master?

@cebe

cebe commented Dec 15, 2020

Copy link
Copy Markdown
Owner

Thank you! I'll check that.

@cebe

cebe commented Dec 15, 2020

Copy link
Copy Markdown
Owner

whatever happened to travis, their open source tests are having a large backlog, can't check the tests for different systems this way :-/

@canvural

Copy link
Copy Markdown
Contributor Author

Basically, travis-ci.org is shutting down soon. And now there will be no free builds for OSS projects. 🤷‍♂️ If I understood correctly.

@cebe

cebe commented Dec 15, 2020

Copy link
Copy Markdown
Owner

seems like that, I'm implementing github actions right now.

cebe added a commit that referenced this pull request Dec 15, 2020
* php8:
  improved types for phpstan
  PHP8 support
@cebe cebe merged commit 696bfd0 into cebe:master Dec 15, 2020
@cebe

cebe commented Dec 15, 2020

Copy link
Copy Markdown
Owner

Merged your changes, will clean up the build on master. Thank you!

@canvural

Copy link
Copy Markdown
Contributor Author

Thank you @cebe

@cebe

cebe commented Dec 15, 2020

Copy link
Copy Markdown
Owner

Tests are failing here due to a symfony bug 😆 symfony/symfony#39521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support PHP 8

2 participants