Skip to content

fix(electron): support loopback renderer passkeys#8925

Merged
wobsoriano merged 1 commit into
jw/electron-package-scaffoldfrom
jw/harden-loopback-detection
Jun 19, 2026
Merged

fix(electron): support loopback renderer passkeys#8925
wobsoriano merged 1 commit into
jw/electron-package-scaffoldfrom
jw/harden-loopback-detection

Conversation

@jeremy-clerk

@jeremy-clerk jeremy-clerk commented Jun 19, 2026

Copy link
Copy Markdown
Contributor
  • allow Electron passkeys to use renderer WebAuthn on loopback development origins
  • normalize bracketed IPv6 loopback hostnames like [::1]
  • retry native passkeys when renderer WebAuthn reports unsupported public key credentials

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: efe32a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/electron Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jun 19, 2026 12:03am
swingset Ready Ready Preview, Comment Jun 19, 2026 12:03am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 34083484-5285-43d2-93de-e9111f0cf62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@jeremy-clerk jeremy-clerk requested a review from wobsoriano June 19, 2026 00:03
wobsoriano
wobsoriano approved these changes Jun 19, 2026
View reviewed changes

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@wobsoriano wobsoriano merged commit d9e80d1 into jw/electron-package-scaffold Jun 19, 2026
8 checks passed
@wobsoriano wobsoriano deleted the jw/harden-loopback-detection branch June 19, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsoriano wobsoriano wobsoriano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremy-clerk @wobsoriano